Chore/compatibilty symfo7 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliboy50
approved these changes
May 27, 2024
There was a problem hiding this comment.
thank you for the PR
IMO it seems like a big breaking change to drop support for Symfony 6.x which is a pretty recent and still supported Symfony release, could you try to support both ~6.1 and ~7.0? (you can use the ci.yml GHA workflow to assert that it still works fine using both 6.1 and 7.0 versions)
|
@Oliboy50 adding back compatibilty tests for sf6. |
|
@pforesi thank you on my side, I fixed the trigger of the CI, now in order for your branch to be tested against the CI, could you please rebase your branch on top of |
|
@Oliboy50 everything ok ? |
Closed
t-geindre
approved these changes
May 27, 2024
|
Thnaks for your quick support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing deprecation to upgrade to symfony 7
Minor changes on php typing compatibilty (set minimal php version to 8.2)
Fixes #40