Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial release #21

Merged
merged 8 commits into from
May 10, 2024
Merged

Initial release #21

merged 8 commits into from
May 10, 2024

Conversation

ljwoods2
Copy link
Collaborator

@ljwoods2 ljwoods2 commented May 8, 2024 •
edited
Loading

Fixes #9, #10, #12, #13

Changes made in this Pull Request:

  • Implemented observables in zarrtraj reader and writer
  • All code reformatted using black
  • Replaced buffer allocation with empty rather than zeros to reduce IO

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@ljwoods2 ljwoods2 changed the title Develop Initial release May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.32787% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 86.74%. Comparing base (c14c975) to head (4cf993e).
Report is 6 commits behind head on main.

Additional details and impacted files

@ljwoods2 ljwoods2 merged commit 10b92c5 into main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing observables in ZarrTrajWriter not implemented
1 participant
@ljwoods2