Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] custom transport prep work #38640

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Nov 21, 2024

Follow-up to #37419, which I had previously closed.

As part of the HTTP/2 readiness for the SDK, in order to handle custom transports, there was a couple things we had to do:

  • make sure we can deal with response.content, which will be the new way to process the response data
  • remove areas where we are manually setting values into response headers, since the possibility exists of now receiving immutable response headers due to HTTP/2's performance optimizations

With these changes we ensure our SDK is HTTP/2 ready.

Also took the opportunity to update our logs to reflect what it should actually have looked like for the logger setup to work as expected when used on a per-request basis - just having the logger named azure would make it a parent that would log all of the requests due to the policy's call to super.__init__().

@simorenoh simorenoh requested review from annatisch and a team as code owners November 21, 2024 18:20
@simorenoh simorenoh changed the title Http2 move header [Cosmos] HTTP/2 prep work Nov 21, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@simorenoh simorenoh changed the title [Cosmos] HTTP/2 prep work [Cosmos] custom transport prep work Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants