Removing SWT authentication handler #10654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
commented
Nov 25, 2024
| private AuthenticateResult HandleAuthenticate() | ||
| { | ||
| string token = null; | ||
| if (!_hostingConfigOptions.Value.SwtAuthenticationEnabled || !Context.Request.Headers.TryGetValue(ScriptConstants.SiteRestrictedTokenHeaderName, out StringValues values)) |
There was a problem hiding this comment.
As you can see, this handler was already deactivated anyways because the default for the SwtAuthenticationEnabled hosting config was False, and no stamps are currently configured to override this with True. So it's safe to remove all this code.
mathewc
commented
Nov 25, 2024
| response = await _fixture.Host.HttpClient.SendAsync(request); | ||
| Assert.Equal(HttpStatusCode.OK, response.StatusCode); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task HostAdminApis_IgnoresSwtTokenWhenDisabled() | ||
| public async Task HostAdminApis_IgnoresSwtTokens() |
There was a problem hiding this comment.
Retaining this negative test for now. I'll remove it when I remove the remaining SWT support (outgoing).
jviau
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the year, I had already deactivated the SWT authentication handler (in this PR). Those changes have been fully released.
In this PR I'm just cleaning this dead code up now - removing the auth handler and supporting code. This handles incoming SWTs (no longer supported). I'll handle outbound SWTs in an upcoming PR. There are only 2 outbound calls SWTs are included on, and those can be controlled via hosting config. So for that, we'll do hosting config testing first, then follow up with code removal.
I will be backporting this to the in-proc branch, but no further.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md