-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hosting config support to control 3.x log disablement #10552
Open
liliankasem
wants to merge
5
commits into
v3.x
Choose a base branch
from
liliankasem/v3/hostlogconfig
base: v3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
commented
Oct 21, 2024
liliankasem
force-pushed
the
liliankasem/v3/hostlogconfig
branch
2 times, most recently
from
October 21, 2024 23:17
6ef92cd
to
7383f7b
Compare
fabiocav
reviewed
Oct 23, 2024
src/WebJobs.Script/Config/FunctionsHostingConfigOptionsSetup.cs
Outdated
Show resolved
Hide resolved
liliankasem
force-pushed
the
liliankasem/v3/hostlogconfig
branch
from
October 24, 2024 20:56
9087929
to
de19d65
Compare
src/WebJobs.Script/Extensions/ScriptLoggingBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Configuration/FunctionsHostingConfigOptionsTest.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/ScriptHostEndToEnd/ScriptHostEndToEndTestFixture.cs
Outdated
Show resolved
Hide resolved
jviau
approved these changes
Oct 30, 2024
src/WebJobs.Script/Extensions/ScriptLoggingBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/Extensions/ScriptLoggingBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
liliankasem
force-pushed
the
liliankasem/v3/hostlogconfig
branch
2 times, most recently
from
October 30, 2024 20:02
e9a1ef2
to
8bc251d
Compare
liliankasem
force-pushed
the
liliankasem/v3/hostlogconfig
branch
from
October 31, 2024 17:26
6da31a4
to
e65a5a4
Compare
surgupta-msft
approved these changes
Nov 1, 2024
liliankasem
commented
Nov 1, 2024
{ | ||
get | ||
{ | ||
return GetFeatureOrDefault(ScriptConstants.HostingConfigRestrictHostLogs, "1") == "1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiocav If I am understanding correctly, your requirements would want this to default to false (0) if not set?
Default behavior: logs ON
Hosting config set: logs OFF
Hosting config set, user feature flag opting out: ON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10546
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Logs pre-configuration (during host startup) are unrestricted.
Post-configuration, the log prefixes are determined by the following settings: