-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move maestro out of regional,svc,mgmt as independent conponent #717
Open
jonathan34c
wants to merge
6
commits into
main
Choose a base branch
from
jonachang/id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now, the maestro infrastructure is part of three templates
if we want to move out the maestro parts from these three templates, it should be again three templates with the mentioned scopes. |
jonathan34c
requested review from
bennerv,
geoberle,
janboll,
jmelis,
mjlshen,
niontive,
nwnt,
UlrichSchlueter,
weinong and
whober0521
as code owners
October 16, 2024 17:58
jonathan34c
force-pushed
the
jonachang/id
branch
from
October 16, 2024 20:14
ed207be
to
65da54e
Compare
geoberle
reviewed
Oct 21, 2024
jonathan34c
force-pushed
the
jonachang/id
branch
from
October 22, 2024 17:59
3405557
to
747193c
Compare
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We want to move maestro out of svc, mgmt and regional as an independent component. The reason is that we want to deploy it individually when something is wrong.
Jira:
Link to demo recording:
Special notes for your reviewer