Skip to content

Commit

Permalink
Merge pull request #312 from Automattic/fix-playwright
Browse files Browse the repository at this point in the history
fix(playwright): remove `dbus` from autostart
  • Loading branch information
sjinks authored Aug 8, 2024
2 parents 58991e2 + f98f97c commit ea5ca39
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion features/src/playwright/devcontainer-feature.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Playwright",
"description": "Sets up Playwright into the Dev Environment",
"documentationURL": "https://github.com/Automattic/vip-codespaces/tree/trunk/features/src/playwright",
"version": "1.1.0",
"version": "1.1.1",
"options": {
"enabled": {
"type": "boolean",
Expand Down
2 changes: 2 additions & 0 deletions features/src/playwright/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ if [ "${ENABLED}" = "true" ]; then
playwright-core install-deps
su -s /bin/sh -c 'playwright-core install' "${_REMOTE_USER}"

update-rc.d -f dbus remove

apt-get clean
rm -rf /var/lib/apt/lists/*
;;
Expand Down
6 changes: 6 additions & 0 deletions features/test/playwright/checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ check "node exists and is executable" which node
check "npm exists and is executable" which npm

check "Smoke test" playwright-core --version

# Microsoft's base images contain zsh. We don't want to run this check for MS images because we have no control over the installed services.
if test -d /etc/rc2.d && ! test -e /usr/bin/zsh; then
dir="$(ls -1 /etc/rc2.d)"
check "/etc/rc2.d is empty" test -z "${dir}"
fi

0 comments on commit ea5ca39

Please sign in to comment.