Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PythonOCC v7.8.1 upgrade #36

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PythonOCC v7.8.1 upgrade #36

wants to merge 5 commits into from

Conversation

JJMinton
Copy link
Collaborator

This PR updates pythonocc-core from v7.5.1 to v7.8.1.
This required

  • updates to conda environment definitions
  • replace removed .Nodes().Value(idx) functions with .Node(idx).
  • Replace a number of functions with static methods to avoid deprecation warnings.

As a bonus, I have removed numerous unused imports.

JoeLambourne
JoeLambourne approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@JoeLambourne JoeLambourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I'm recommending updating the major version because we pull in a new PythonOCC which does force consumers to update OCC related code

@JJMinton
Copy link
Collaborator Author

I am getting failures around the read/write of shapesets. The interface was updated from .ReadFromString() to .Read(), as per this PR, but this is raising an error. I have opened an issue with pythonocc so will hold this for a while in hopes of getting a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLambourne JoeLambourne JoeLambourne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJMinton @JoeLambourne