Skip to content

Commit

Permalink
add combine partial to protobuf.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jackson Newhouse authored and mwylde committed May 7, 2024
1 parent 019d66f commit b97a5b6
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions datafusion/proto/proto/datafusion.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1726,6 +1726,7 @@ enum AggregateMode {
FINAL_PARTITIONED = 2;
SINGLE = 3;
SINGLE_PARTITIONED = 4;
COMBINE_PARTIAL = 5;
}

message PartiallySortedInputOrderMode {
Expand Down
3 changes: 3 additions & 0 deletions datafusion/proto/src/generated/pbjson.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions datafusion/proto/src/generated/prost.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions datafusion/proto/src/physical_plan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,9 @@ impl AsExecutionPlan for PhysicalPlanNode {
protobuf::AggregateMode::SinglePartitioned => {
AggregateMode::SinglePartitioned
}
protobuf::AggregateMode::CombinePartial => {
AggregateMode::CombinePartial
}
};

let num_expr = hash_agg.group_expr.len();
Expand Down Expand Up @@ -1471,10 +1474,8 @@ impl AsExecutionPlan for PhysicalPlanNode {
AggregateMode::Single => protobuf::AggregateMode::Single,
AggregateMode::SinglePartitioned => {
protobuf::AggregateMode::SinglePartitioned
},
AggregateMode::CombinePartial => {
unimplemented!()
}
AggregateMode::CombinePartial => protobuf::AggregateMode::CombinePartial,
};

let input_schema = exec.input_schema();
Expand Down

0 comments on commit b97a5b6

Please sign in to comment.