Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ark-physics-kit] tests and abstracting classes #98

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Conversation

markusyeo
Copy link
Contributor

  • Abstract BaseSKScene as AbstractSKScene
  • Protocol AbstractArkSkPhysicsBody to mock SKPhysicsBodyManager
  • Abstract ArkSKPhysicsBody creation to AbstractArkSKPhysicsBodyFactory
  • Add test cases for sprite-kit-physics classes

Copy link
Contributor

@ryanpeh ryanpeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markusyeo markusyeo merged commit 4e2732f into main Apr 21, 2024
1 check passed
@markusyeo markusyeo deleted the tests/physics-kit branch April 21, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants