Modify the memory allocation method of matd_t

Add '-Wpedantic' flag to CMake
AprilRobotics · Nov 16, 2024 · a91a5a3 · a91a5a3
1 parent 4dfd338
commit a91a5a3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -43,7 +43,7 @@ endif()
 
 if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
     add_compile_options(-Wall -Wextra -Werror)
-    # add_compile_options(-Wpedantic)
+    add_compile_options(-Wpedantic)
     add_compile_options(-Wno-shift-negative-value)
 endif()
 

diff --git a/common/matd.c b/common/matd.c
@@ -51,9 +51,10 @@ matd_t *matd_create(int rows, int cols)
     if (rows == 0 || cols == 0)
         return matd_create_scalar(0);
 
-    matd_t *m = calloc(1, sizeof(matd_t) + (rows*cols*sizeof(double)));
+    matd_t *m = calloc(1, sizeof(matd_t));
     m->nrows = rows;
     m->ncols = cols;
+    m->data = calloc(rows * cols, sizeof(double));
 
     return m;
 }
@@ -220,7 +221,8 @@ void matd_destroy(matd_t *m)
     if (!m)
         return;
 
-    assert(m != NULL);
+    assert(m->data != NULL);
+    free(m->data);
     free(m);
 }
 

diff --git a/common/matd.h b/common/matd.h
@@ -45,8 +45,7 @@ extern "C" {
 typedef struct
 {
     unsigned int nrows, ncols;
-    double data[];
-//    double *data;
+    double *data;
 } matd_t;
 
 #define MATD_ALLOC(name, nrows, ncols) double name ## _storage [nrows*ncols]; matd_t name = { .nrows = nrows, .ncols = ncols, .data = &name ## _storage };