Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: long, ValueError message when list KeyError [APE-1517] #35

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix: long, ValueError message when list KeyError [APE-1517] #35

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f77c0c8
fix: weird repr of token manager
antazoey Jul 28, 2023
dc304ed
fix: access repr
antazoey Nov 6, 2023
2264abc
Merge branch 'main' into fix/repr
antazoey Nov 6, 2023
94e0a1e
fix: bump tokenliss
antazoey Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: v4.5.0
hooks:
- id: check-yaml

Expand All @@ -10,24 +10,24 @@ repos:
- id: isort

- repo: https://github.com/psf/black
rev: 23.7.0
rev: 23.10.1
hooks:
- id: black
name: black

- repo: https://github.com/pycqa/flake8
rev: 6.0.0
rev: 6.1.0
hooks:
- id: flake8

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.4.1
rev: v1.6.1
hooks:
- id: mypy
additional_dependencies: [types-setuptools, pydantic]

- repo: https://github.com/executablebooks/mdformat
rev: 0.7.16
rev: 0.7.17
hooks:
- id: mdformat
additional_dependencies: [mdformat-gfm, mdformat-frontmatter]
Expand Down
9 changes: 5 additions & 4 deletions ape_tokens/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from eth_utils import to_checksum_address
from tokenlists import TokenListManager

ERC20 = ContractType(
**{
ERC20 = ContractType.parse_obj(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: did parse_obj to resolve a novel mypy complaint

{
"contractName": "ERC20",
"abi": [
{
Expand Down Expand Up @@ -119,8 +119,9 @@ def __getitem__(self, symbol: str) -> ContractInstance:
symbol, chain_id=self.network_manager.network.chain_id
)

except ValueError as e:
raise KeyError(f"Symbol '{symbol}' is not a known token symbol") from e
except ValueError as err:
message = f"Symbol '{symbol}' is not a known token symbol"
raise KeyError(message) from err

return self.chain_manager.contracts.instance_at(
to_checksum_address(token_info.address), contract_type=ERC20
Expand Down
8 changes: 4 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
"hypothesis>=6.2.0,<7.0", # Strategy-based fuzzer
],
"lint": [
"black>=23.7.0,<24", # auto-formatter and linter
"mypy>=0.991", # Static type analyzer
"black>=23.10.1,<24", # auto-formatter and linter
"mypy>=1.6.1,<2", # Static type analyzer
"types-setuptools", # Needed due to mypy typeshed
"flake8>=6.0.0,<7", # Style linter
"flake8>=6.1.0,<7", # Style linter
"isort>=5.10.1,<6", # Import sorting linter
"mdformat>=0.7.16", # Auto-formatter for markdown
"mdformat>=0.7.17", # Auto-formatter for markdown
"mdformat-gfm>=0.3.5", # Needed for formatting GitHub-flavored markdown
"mdformat-frontmatter>=0.4.1", # Needed for frontmatters-style headers in issue templates
],
Expand Down