Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network gas transaction issues [APE-1434] #18

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 4, 2023

What I did

issues where network gas limit was not honored, settings were missing, and just general lack of functioning.
i had to copy a lot of fixes from other areas while maintaining the bsc-specific differences.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: network gas transaction issues fix: network gas transaction issues [APE-1434] Oct 4, 2023
@antazoey antazoey requested a review from dtdang October 4, 2023 20:40
@antazoey antazoey merged commit 794cb9c into ApeWorX:main Oct 4, 2023
11 checks passed
@antazoey antazoey deleted the chore/updates branch October 4, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants