-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 🔒 Warning for the end of support for Python 3.8
is approaching
#1608
Conversation
Review changes with SemanticDiff. Analyzed 1 of 1 files.
|
Reviewer's Guide by SourceryThis pull request adds a warning message for the upcoming end of support for Python 3.8 in the SpectraFit project. It modifies the File-Level Changes
Sequence DiagramNo sequence diagram generated. Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4464 4468 +4
=========================================
+ Hits 4464 4468 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Python 3.8
is approaching #1607Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Introduce a warning for users about the upcoming end-of-life for Python 3.8 support in SpectraFit, and update the documentation to reflect this change.
New Features:
Documentation: