Redesign the TUI Footer #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change: Eliminate `original_widget` indirection for the `key_bar` and `expand` widgets. - Change: Use `Text.pack()[0]` instead of `len(Text.text)`. - Change: Use PACK sizing for `expand` within the footer (`bottom_bar`).
- Add: `key_bar_cols()`. - Change: Simplify `adjust_bottom_bar()`. - Change: Only update the height of the footer (`bottom_bar` widget) when the height changes.
- Add: "action" and "disabled action" TUI palette entries. - Change: Simplify the design of the keys and action names. - Change: Use plain/default colors, improving the contrast for disabled actions. - Change: Update the "key" and "disabled key" TUI palette entries.
AnonymouX47
added
improvement
- Change: Rename the footer widgets: - `key_bar` -> `action_bar` - `bottom_bar` -> `footer` - Change: Rename `.tui.keys.adjust_bottom_bar()` -> `adjust_footer()`. - Change: Rename the "global" context action "key Bar" -> "Expand/Collapse Footer" and update its description. - Change: Update terminology "bottom bar", "action/key bar" -> "footer".
- Add: `.keys.update_expand_collapse_icon()`. - Change: Display the expand key using the new style. - Change: Simplify updating the footer expand/collapse icon. - Change: Update comments.
- Change: Include *bold* setting in "key" display attribute.
- Change: Update the action bar only if the updated context is the current or global context. - Change: Update the action bar only once when actions are hidden or shown.
- Add: `.widgets.ActionBar()`.
- Replaces the `Text` widget used to display context actions in the
footer.
- Provides better wrapping of actions, particularly when an action's
widget is less in width than the action bar.
- Change: Remove `.keys.display_context_keys()`.
Replaced by `action_bar.update()`.
- Add: `Action`.
- Replaces the `Text` widgets used to display actions in the action
bar.
- Triggers the action on left mouse button clicks, if enabled and
bound to a function.
- Change: Do not use bare `Action` widgets within `ActionBar`; they must
always be within a `Columns` widget to prevent accidentally triggering
an action alone on a row when clicking off the action but on the row.
- Add: Implement the `show footer` config option. - Change: The "global::Expand/Collapse Footer" action is now disabled when the footer is hidden. - Change: Make footer and action bar operations no-op when the footer is hidden. - Change: Update the positioning of the info bar to work properly when the footer is hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show footerconfig option to control the TUI footer visibility.Resolves #17