New forced-photometry loaders #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.9.2 can read pre-4.0 ZTF alert schemas again fastavro/fastavro#738 fastavro/fastavro#723
deps: bump requests-toolbelt to 1.0
NB: this skips tests that depend on arbitrary secrets like ARCHIVE_TOPIC_TOKEN
* chore(deps): update minor updates * chore(deps): bump ampel-core --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jakob van Santen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus spake our Metal Lord 🤖:
This pull request introduces several significant changes across multiple files to enhance the functionality and performance of the Ampel-ZTF project. The most important changes include the addition of a new alert supplier, updates to existing alert suppliers, and improvements to data point shaping and tabulation.
New Features:
ampel/ztf/alert/BTSForcedPhotometryAlertSupplier.py: Added a new alert supplier classBTSForcedPhotometryAlertSupplierfor handling baseline corrected IPAC forced photometry files produced by the BTS group. This class includes methods for loading and processing photometry data, handling candidate coordinates, and generating alerts.ampel/ztf/view/ZTFFPTabulator.py: Introduced a new tabulator classZTFFPTabulatorfor filtering and tabulating forced photometry data points. This class includes methods for filtering detections, creating flux tables, and retrieving positions and stock IDs.Updates to Existing Alert Suppliers:
ampel/ztf/alert/ZTFFPbotForcedPhotometryAlertSupplier.py: Modified theget_fpbot_baselinefunction to return a tuple instead of a DataFrame, and updated several lines to use dictionary-style access for DataFrame columns. [1] [2] [3] [4] [5]Data Point Shaping Improvements:
ampel/ztf/ingest/ZiDataPointShaper.py: Enhanced theZiDataPointShaperBaseclass by adding adigest_sizeattribute and a_create_datapointmethod for creating data points with hashed IDs. This update also includes handling of forced photometry data points. [1] [2] [3] [4]Other Changes:
ampel/ztf/alert/cal_data/zp_thresholds_quadID.txt: Added a new file containing CCD-quadrant-based ZP thresholds for identifying bad quality images.These changes collectively enhance the system's ability to process and analyze photometry data, improving both functionality and performance.