Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
hajungIm
approved these changes
May 23, 2024
09_백트랙킹/필수/14888.cpp
Outdated
| case 3:{ | ||
| getResult(result/operand[idx], idx+1); | ||
| break; | ||
| } |
There was a problem hiding this comment.
한 가지 피드백을 드린다면,
변하지 않는 값을 상수값으로 정의해서 사용해보세용!
const int ADD = 0, SUB = 1, MUL = 2, DIV = 3;
// 생략...
switch(i) {
case ADD:{
// 더하기 로직
}
}
09_백트랙킹/필수/15665.cpp
Outdated
There was a problem hiding this comment.
결과를 중복을 피해 s에 저장해서 한번에 출력하는 부분 좋았습니다!👍🏻
구현 잘하셨습니당😊
| v.push_back(arr[i]); | ||
| s.insert(v); | ||
| v.clear(); | ||
| }else { |
There was a problem hiding this comment.
이럴때 else를 쓰기보다,
if (k==M) 만족 시 return 하는 방식을 사용해보세용!
코드를 더 깔끔하게 만들 수 있습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
학번: 2276107
이름: 문재원
과제
기존제출: 14888, 15665
추가제출: 2477