Enable cross-releasing between platforms #1058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lmaLinux-10 platform, and the other way around Resolves AlmaLinux/build-system#369: - For cross-releasing we should include an RPM artifact if the reference platforms of its build task has intersection with the reference platform of base platform which we want to release a build
soksanichenko
changed the title
anfimovdm
requested changes
Nov 20, 2024
alws/release_planner.py
Outdated
| @@ -67,6 +67,7 @@ | |||
|
|
|||
| class BaseReleasePlanner(metaclass=ABCMeta): | |||
| def __init__(self, db: AsyncSession): | |||
| self.base_platform = None # type: typing.Optional[models.Platform] | |||
There was a problem hiding this comment.
Please, do not mix type annotations in the code with type comments, just use annotation instead
maccelf
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves AlmaLinux/build-system#369:
...if the reference platforms of its build task has intersection with...
...the reference platform of base platform which we want to release a build