Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urlencode indicator in the URL #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bieron
Copy link

@bieron bieron commented Sep 3, 2017

Server returns HTTP 400 when queried for details on URL-unsafe indicators, especially of type IndicatorType.URL. The encoding should be the responsibility of the API, because

  1. the actual implementation of query is encapsulated in its methods, users don't even know it is sent in URL
  2. for consistency, API should be able to handle the same format (URL-unsafe that is) of IoCs that it returns, without any need for processing by the user

I'm sorry I didn't write any test for it, can't make the test to work, tried substituting X_OTX_DEV_SERVER=https://otx.alienvault.com/ to no avail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant