Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration notebook text #803

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

sjspielman
Copy link
Member

Closes #802

This PR updates a sentence (or two) in the notebook to be more open-ended and less prescribed about the harmony results, which are slightly different in the new harmony version in our environment. This wording also has the benefit of probably never needing to be modified again and will remain robust in the face of future harmony versions/changes!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjspielman sjspielman merged commit 480923d into master Nov 8, 2024
2 checks passed
@sjspielman sjspielman deleted the sjspielman/802-integration-text branch November 8, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update integration text
2 participants