Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Lindsey and Bennett - RideShare #5

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

bennettrahn
Copy link

@bennettrahn bennettrahn commented Oct 2, 2017

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way Driver has many Trips, Passenger has many Trips, each Trip has one Driver and one Passenger.
Describe the role of model validations in your application Model validations make sure that the data in the database is correct. At the moment I don't have the structure in place to prevent against dependency deletions, which I probably should.
How did your team break up the work to be done? Um, not sure how Lindsey would feel about the answer to this question, but I'm very certain that everything in this final version has been completed by me. Lindsey worked a little bit on a couple things, but most of them needed to be rewritten anyway.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? I didn't fix the problem where the database takes 3.45 and turns it into 3. I'm sure I could have figured it out but I was pretty fed up by the end so I had very little bandwidth. Otherwise I think all the specifications were met. I would have loved to work more on the CSS - playing with dropdown menus, field prompts, and star ratings, but because I was finishing the basic specs, I didn't really have time.
What was one thing that your team collectively gained more clarity on after completing this assignment? I know how to make a rails app that uses relational data, which is cool. I also learned a lot about databases in general, I feel slightly more comfortable with forms, partials, and model methods. Also deploying to heroku was cool - I didn't actually have any problems with deployment, so I look forward to having lots of issues in the future and learning how to troubleshoot.
What is your Trello URL? https://trello.com/b/aBCf9iyV/rideshare
What is the Heroku URL of your deployed application? https://bennett-and-lindsey-rideshare.herokuapp.com/

@droberts-sea
Copy link

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing yes
Answered comprehension questions yes
Uses named routes (like _path) yes
RESTful routes utilized yes
Rideshare Rails Specific Content
Table relationships yes
Validation rules for Models yes
Business logic is in the models yes - great work
Database is seeded from the CSV files yes
Trello board is created and utilized in project management yes
Postgres database is used yes
Heroku instance is online yes
The app is styled to create an attractive user interface yes
Overall Good job overall. I'm especially happy with how you've pushed business logic down into the Model, rather than letting it creep into controllers and views. Keep up the hard work.

# redirect_back(fallback_location: @trip)
else
render :new
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to render :edit here. Redirecting to the new trip page is not what I expected when testing the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants