RideShare - Carets - Marisa Morris & Isabel Suchanek

[marisamorris]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	One to many. One driver has many trips and one passenger has many trips.
Describe the role of model validations in your application	Requires form information so its easier to capture information and to notify the user that they need to add in information.
How did your team break up the work to be done?	Pair programmed throughout the project with the exception of CSS.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	In regard to what was prioritized, we chose to focus on basic functionality making sure the program worked. We set aside using nested routes because we didn't understand best practice and implementation.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Validations and form helpers
What is your Trello URL?	https://trello.com/b/jb5g6py4/ride-share-pp
What is the Heroku URL of your deployed application?	https://stark-woodland-89992.herokuapp.com/

[tildeee]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	didn't use resources, but still accomplished this well
Rideshare Rails Specific Content
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Postgres database is used	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

[tildeee]

What happens if there are no trips associated with the driver? Then this above line will execute with counter = 0 and rating = 0. In Ruby, 0.0/0 evaluates to NaN (Not a Number), so in the driver show page, if there are no trips associated with the driver, then NaN.to_s will evaluate to the string "NaN" and is shown on the page.

[tildeee]

Good work with the site! It looks really nice and works really well. It accomplishes all of the requirements. I left a comment on one little bug where it shows "NaN" on page. Good job continuing to use the Trello board