Tanja and Averi -- RideShareRails -- Carets

[misstonbon]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trips belong to both drivers and passengers. Passengers and Drivers have many trips. We also set the app up so only passengers can start trips (as they are the ones requesting rides in a supply and demand business model).
Describe the role of model validations in your application	We were validating the presence of name and vin and phone number and numericality of reviews and price.
How did your team break up the work to be done?	We mostly worked together during project time, tweaking styling and functionality during "time off" as we went. We didn't take turns driving and navigating but we did divide tasks as mutually agreed on.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized getting all functionality up and running , and focused on styling last.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained clarity on putting defs in Models rather than Controller with Charles' help, and we are proud of the search bar functionality, as navigating all those names is tedious without it. Also, added paginate so that index page is not so crowded. Very happy about that.
What is your Trello URL?	https://trello.com/b/W4f5XuN1/ridesharerails
What is the Heroku URL of your deployed application?	https://tanja-averi-rideshare.herokuapp.com/

[CheezItMan]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Good use of Git with both teammates checking in work. Good commit messages.
Answered comprehension questions	Check
Uses named routes (like _path)	Check, you used, resources, good
RESTful routes utilized	Check
Rideshare Rails Specific Content
Table relationships	Check
Validation rules for Models	Check, good use of presence, and limited values of ratings and prices.
Business logic is in the models	Very good here. Nice work putting those methods in the models.
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check.
Postgres database is used	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Check
Overall	You hit all the requirements. Well done. For later functionality, if there was time, I would think about ways a passenger can submit a rating without editing the entire trip and ways for a driver to go on and off duty in a similar manner. Really good work moving business logic into the models. The styling is simple and effective. Good use of semantic HTML.

[CheezItMan]

An enumerable would go well here. :D

[CheezItMan]

This method seems a repetition of the same functionality in driver.rb.

[CheezItMan]

Nice use of pagination!