Pipes - Sarah Read-Brown - ApiMuncher

[SRBusiness]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used a combination of postman and httparty in pry to play with the api and the various responses until I decided how I wanted to handler the api responses for positive and negative outcomes.
Describe your API Wrapper. How did you decide on the methods you created?	I essentially followed the steps we went through in class to make an api wrapper. I initially wrote a helper method that aid in building the urls but it became cumbersome when the two different api calls diverged significantly so I discarded it.
Describe an edge case or failure case test you wrote for your API Wrapper.
Explain how VCR aids in testing an API.	VCR records the api responses so that when you test you don't have to make new api calls each time you test.
What is the Heroku URL of your deployed application?	I don't have a functioning heroku app. I had some issues with my routes that I couldn't trouble shoot on my own that stopped me from doing controller testing and caused my heroku app to crash every time I tried to deploy it. I'd love to get some help from an instructor to trouble shoot this, I spent a lot of time on my own this weekend working on it but decided that it would be worth creating a pull request and submitting what I had built so far.

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Some Improvement - make sure to answer all questions (one is missing)
General
Rails fundamentals (RESTful routing, use of named paths)	Mostly Good - The route for show is not following REST conventions, instead it should still use the recipes pluralized, and take a unique identifier it.
Semantic HTML	Some Improvement - header and footer should still be inside of the body tags. The most appropriate tag to wrap around yield would be main.
Errors are reported to the user	Not Complete - should show error in application interface (using flash messages), not through better_errors
API Wrapper to handle the API requests	Mostly Good - I'm curious to know why recipe is initially set to an empty string in show_recipe
Controller testing	Not Complete - only has root and one positive for index
Lib testing	Well Done - Should have one for when no recipes are returned
Search Functionality	Well Done
List Functionality	Well Done
Show individual item functionality (link to original recipe opens in new tab)	Mostly good - link to original recipe page should open in a new tab.
Styling
Foundation Styling for responsive layout	Well Done
List View shows 10 items at a time/pagination	Well Done
The app is styled to create an attractive user interface	Well Done - nice use of current_page helper to display header
API Features
The App attributes Edaman	mostly good - should link to edamam site
The VCR cassettes do not contain the API key	Well Done
External Resources
Link to deployed app on Heroku	Not complete
Overall
Areas for Improvement	Handling errors to show as flash messages to user in browser, Controller Testing and Resolving issues while deploying to Heroku