Pipes - Iuliia - Muncher #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API MuncherWhat We're Looking For
|
|
|
||
| must_respond_with :success | ||
| end | ||
| end |
There was a problem hiding this comment.
There are some interesting test cases around paging that you're missing here:
- Does the page still render if paging parameters are passed?
- What if the paging parameters are invalid (negative number, etc)?
- What if the paging parameters take you past the end of the available search results?
| describe "show_recipe" do | ||
| it "returns data for a recipe" do | ||
| VCR.use_cassette("recipe") do | ||
| uri = "637913ec61d9da69eb451818c3293df2" |
There was a problem hiding this comment.
I would also like to see a negative test case here - what happens if the URI is invalid?
|
|
||
| it "raises an ApiError when the credentials are bad" do | ||
| VCR.use_cassette("no recipes") do | ||
| proc { EdamamApiWrapper.search_recipes("fish", "invalid_app_id", "invalid_app_key") }.must_raise EdamamApiWrapper::ApiError |
There was a problem hiding this comment.
What about for a search with no hits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions