API-Muncher Marisa Morris #33

marisamorris · 2017-11-06T16:56:15Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	Returning all of the data and then used nesting to step into to main hash further.
Describe your API Wrapper. How did you decide on the methods you created?	My API wrapper contains two methods. A list_recipes method and a show recipe method. As I only needed to display a list of recipes and show an individual recipe, I didn't see the need for any additional. One change i could have made would have been to create a method that pulls the pieces of data i need so that each method can have a single responsibility.
Describe an edge case or failure case test you wrote for your API Wrapper.	Will return [] for a broken request. If someone searches for nothing, an empty array is returned.
Explain how VCR aids in testing an API.	VCR is a tool that allows your tests to record HTTP interactions and replay them when necessary
What is the Heroku URL of your deployed application?	http://theguiltycarb.herokuapp.com/

… up on pages that are not the homepage.

…ndation 6

CheezItMan · 2017-11-07T19:34:18Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commit and commit messages
Comprehension questions	Check, I would also emphasize that VCR keeps you from running too many api calls
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	You've got a few too many `div` elements
Errors are reported to the user	Wrong show URLs crash the app, otherwise no errors reported
API Wrapper to handle the API requests	Check, but more defensive programming needed
Controller testing	Check, but no negative-case tests
Lib testing	Check, but no negative-case tests
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check
Styling
Foundation Styling for responsive layout	Your site simply shrinks the results as the browser gets smaller. This results in an unpleasant experience on a mobile device. Using grid-layout would be better. Something to work on in JavaScript!
List View shows 10 items at a time/pagination	Nice work!
The app is styled to create an attractive user interface	The styling is pretty nice.
API Features
The App attributes Edaman	Attribution is there, but no link
The VCR casettes do not contain the API key	Check
External Resources
Link to deployed app on Heroku	Check
Overall	Overall well done. You had some oversights in testing which expose problems in your app. I left some notices in your code. Overall not bad.

CheezItMan · 2017-11-07T19:27:56Z

test/lib/edamam_api_wrapper_test.rb

+
+  describe "show_recipe" do
+
+    it "Can show a requested recipe" do


What about a negative case?

CheezItMan · 2017-11-07T19:28:47Z

test/controllers/home_controller_test.rb

@@ -0,0 +1,8 @@
+require "test_helper"
+
+class HomepageControllerTest < ActionDispatch::IntegrationTest


This should probably be removed.

CheezItMan · 2017-11-07T19:29:16Z

test/controllers/recipes_controller_test.rb

+require 'test_helper'
+
+# class RecipesControllerTest < ActionDispatch::IntegrationTest
+describe RecipesController do


Again negative-case tests are needed!

CheezItMan · 2017-11-07T19:30:17Z

app/views/layouts/application.html.erb

+      <div class="grid-x">
+        <div class="large-2 medium-1 small-3 cell"></div>
+
+          <div class="large-8 medium-10 small-6 cell blah">


CheezItMan · 2017-11-07T19:31:50Z

lib/edamam_api_wrapper.rb

+    # MUST ENCODE THE SEARCH PARAMETER IN THE URL
+    url = BASE_URL + "?r=" + (URI.encode(search))
+
+    data = HTTParty.get(url)


You need some error-detection here! What if data or data[0] are nil?

HelloMarisaMorris added 22 commits October 30, 2017 22:00

set up .env, application.rb, and the start of the edamam wrapper

347813c

added a hompage controller

87d54b2

api wrapped list recipes method complete and started index pages

f9da409

index page encoded url and displaying 100 recipes

3a55135

added encode to wrapper. show page working

a450b78

show page includes all required info with the excpetion of pagination.

8cf9a6a

Recipe class tests passing. VCR set up

a9d320a

added testing gem

f2e0a0a

recipe controller tests passing

e5d12d7

list_recipes wrapper tests passing

a0507b3

conditional added to application.html.erb for nav bar. Will only show…

b1a2856

… up on pages that are not the homepage.

added css grid

50887ad

css grid and mild styling. had to create an override file for css fou…

fe363d7

…ndation 6

updated grid on hompage and index

aca64be

added footer and updated foundation pagination.

d136e9b

show page styling

a72b29d

updated font families

84360d9

updated sccs

8803a44

updated footer

61687d2

updated font

03bb042

removed comment

6d64079

updates

185a8e3

CheezItMan reviewed Nov 7, 2017

View reviewed changes

HelloMarisaMorris added 3 commits November 7, 2017 19:03

added simple cov

761d876

added 1 edge case for recipe.rb

4c08c5b

added a few edge case tests

2279cec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API-Muncher Marisa Morris #33

API-Muncher Marisa Morris #33

marisamorris commented Nov 6, 2017 •

edited

Loading

CheezItMan commented Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017


		describe "show_recipe" do

		it "Can show a requested recipe" do

		@@ -0,0 +1,8 @@
		require "test_helper"

		class HomepageControllerTest < ActionDispatch::IntegrationTest

API-Muncher Marisa Morris #33

Are you sure you want to change the base?

API-Muncher Marisa Morris #33

Conversation

marisamorris commented Nov 6, 2017 • edited Loading

API Muncher

Comprehension Questions

CheezItMan commented Nov 7, 2017

API Muncher

What We're Looking For

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

marisamorris commented Nov 6, 2017 •

edited

Loading