Jan Edrozo | Carets #32

JNEdrozo · 2017-11-06T13:31:45Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I reviewed the Edamam documentation and tested request paths in Postman (occasionally using awesome print to confirm responses).
Describe your API Wrapper. How did you decide on the methods you created?	I have 2 self methods (show_recipe and list_recipes) so I could retrieve a list of recipes (based on search term) as well as retrieve info for a specific recipe (using its uri).
Describe an edge case or failure case test you wrote for your API Wrapper.	A fail case would be for a bad request (e.g. a search term that does not have any recipe results like a number), and I tested to make sure it returns an empty array
Explain how VCR aids in testing an API.	VCR aids in testing because it reduces the number of API calls we make since we can reuse API responses stored in the cassettes.
What is the Heroku URL of your deployed application?	https://recipoogle.herokuapp.com/

…hash symbol syntax)

…ded the dotenv gem to read the app_id and key in the .env file

…ecipes to simplify options hash readability

…ser enters a search term (does not exclude spaces)

… (switched condition order)

…tion.rb

…dated development group in gemfile

…ifications)

CheezItMan · 2017-11-06T22:43:26Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Very good commits!
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Good semantic HTML, I think some of the `div` elements could be removed.
Errors are reported to the user	You have flash notices, but did not put them in the views!
API Wrapper to handle the API requests	Check
Controller testing	Well done here
Lib testing	No testing on the show recipe method.
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check, but not in a new tab
Styling
Foundation Styling for responsive layout	Check
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	Very nicely styled here.
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	Check
External Resources
Link to deployed app on Heroku	Well done
Overall	Very nicely done, you missed a couple of tests in your wrapper, but I think that was just an oversight. Well done!

CheezItMan · 2017-11-06T22:36:35Z

test/lib/edamam_api_wrapper_test.rb

+  end
+
+  describe "self#list_recipes" do
+    it "Can list a group of channels" do


Something's missing here!

CheezItMan · 2017-11-06T22:38:00Z

test/lib/edamam_api_wrapper_test.rb

+      end
+    end
+  end
+end


Tests for the show_recipe method?

CheezItMan · 2017-11-06T22:39:16Z

test/controllers/recipes_controller_test.rb

@@ -0,0 +1,68 @@
+require "test_helper"
+
+describe RecipesController do


Good set of tests here.

JNEdrozo added 30 commits October 31, 2017 15:52

Initial Set Up with edamam_api_wrapper.rb

2c12cf7

edamam_api_wrapper.rb#list_recipes (need to fix the image and source …

63a7127

…hash symbol syntax)

Updated edamam_api_wrapper#list_recipes method and Recipe.rb; also ad…

f0e0781

…ded the dotenv gem to read the app_id and key in the .env file

Recipe_test.rb: Added initialize tests

185632b

Added basic self#list_recipes for 2 basic tests (mirrored from SlackAPI)

8cf7b19

Generated a Controller (recipes)

81ff255

Edamam_api_wrapper_test.rb (added test fr wrong app id and key)

1ababf6

Updated routes.rb with 3 get routes (index, search, show)

a617edf

Added recipe_payload.json sample text and updated api_wrapper #list_r…

fc02d5a

…ecipes to simplify options hash readability

added will_paginate

25f94bd

Added recipes show link in index page

ae6714f

Added EdamamApiWrapper#show_recipe(uri%23conversion)

532e008

Updated Recipe#show view with basic wireframe elements

d0ec531

Added Home page with footer and Edamam attribution link

d0fb276

Added render_404 to show (if recipe is nil)

0bcfae6

removed config.enable_dependency_loading = true from production.rb

ae9ab74

Raind rails db:migrate to create schema(to troubleshoot heroku)

6172421

Added required='required' to search form's text_field_tag to ensure u…

c1c5203

…ser enters a search term (does not exclude spaces)

Fixed RecipesController#index method to prevent empty string searches…

6d90a54

… (switched condition order)

Updated RecipeController tests (still need to fix show test and id)

1975845

Correction: RecipeController#show (removed render_404 condition)

1806a97

Updated index styling so recipes are boxes rather than a list

8b89016

Added Gale Tip on EdamamApiWrapper issue in application.rb and produc…

6bbcf61

…tion.rb

Removed production.rb typo in production.rb file

f1843b7

Moved httparty gem outside of test and dev

b1f2f5b

Application.rb(removed config.autoload_paths << Rails.root.join('lib'))

85a50fa

Moved gem awesome_print out of development and test group and consoli…

8d13417

…dated development group in gemfile

Review basic tests for controller and lib

183e6c2

Styling: Moved footer position to bottom of page

8308b13

Added a favicon to application.html.erb

4d8a2bd

JNEdrozo added 8 commits November 6, 2017 00:15

Styling: Added @media screen for home page (title and search bar spec…

4954a50

…ifications)

Added application title

b59b113

Search Header styled

0ea7b32

Home page finalized

1e333f8

Updated index styling

f16048f

Updated show page styling

034af87

background url change

b5c33bd

Updated link styling

ce9d6e8

CheezItMan reviewed Nov 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jan Edrozo | Carets #32

Jan Edrozo | Carets #32

JNEdrozo commented Nov 6, 2017

CheezItMan commented Nov 6, 2017

CheezItMan Nov 6, 2017

CheezItMan Nov 6, 2017

CheezItMan Nov 6, 2017

		@@ -0,0 +1,68 @@
		require "test_helper"

		describe RecipesController do

Jan Edrozo | Carets #32

Are you sure you want to change the base?

Jan Edrozo | Carets #32

Conversation

JNEdrozo commented Nov 6, 2017

API Muncher

Comprehension Questions

CheezItMan commented Nov 6, 2017

API Muncher

What We're Looking For

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment