Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets - Guillermina #31

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Carets - Guillermina #31

wants to merge 46 commits into from

Conversation

murog
Copy link

@murog murog commented Nov 6, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I read through the documentation and found an example on how to conduct a query using the word "chicken." I played with the parameters on the link to figure out how to get what I needed out of the API.
Describe your API Wrapper. How did you decide on the methods you created? My API Wrapper only has two methods. Reviewing them, I could have created some helper methods to DRY up the code since they are kind of long. The first one "self.list_recipes" takes in a params hash and pulls information it needs out of it to make a request. If a "from" and "to" range is not include, it makes the query starting a 0 and ending at 10. It also updates the url if a health label is given in the params. If the query is successful, it returns an array of recipe objects. If the query is unsuccessful, it returns an empty array. The second method, "self.find_recipe", takes in a recipe uri (as a string) and makes a request based on the uri. If it is successful, it will return a recipe object. If it is not, it returns false.
Describe an edge case or failure case test you wrote for your API Wrapper. An edge I tested for was that it would be able to successfully make a request on a multi word query that includes blank spaces. It was successful, which surprised me!
Explain how VCR aids in testing an API. VCR saves requests you make on an API. When you make a duplicate requests, it will compare your test again the saved response from the past. This is helpful because it minimizes the amount of calls you make on an API and reduces the chances of you getting timed out or banned from using their service.
What is the Heroku URL of your deployed application? http://gm-muncher.herokuapp.com/

…ith health labels and single/multi word search queries
…t is due to being timed out by app?? will try later
…e object, controller populate show page with relevant recipe info
…ude provider, can log in using google_login_path
@CheezItMan
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Check
Errors are reported to the user No error reported
API Wrapper to handle the API requests Check
Controller testing Check
Lib testing Check
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab)
Styling
Foundation Styling for responsive layout Responsive, but the tables aren't great for smaller screens.
List View shows 10 items at a time/pagination Check, but the pagination is there even for 0 results.
The app is styled to create an attractive user interface Nicely attractive.
API Features
The App attributes Edaman Check
The VCR casettes do not contain the API key Check
External Resources
Link to deployed app on Heroku Check
Overall Great work on the Google OAuth! Well done, you hit all the major requirements. Awesomework!

end
end

it "will render 404 for a bogus recipe" do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also run a test with a search term that gets no responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants