Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura Robertson -- Carets #28

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

LauraAddams
Copy link

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How do Backbone Views help structure your code? It splits everything into small, readable files(too many!) and follows a structural MVC pattern.
Did you use jQuery directly in your Views? How, and why? I used it as a selector, typically when emptying the selected section.
What was an example of an event you triggered? Why did you need to trigger it? I triggered the buying/selling of orders. I needed to trigger it so my quoteView could listen and know which quote to buy based on the function buyOrder/sellOrder.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different? A lot of the syntax and vocabulary is very similar, however most tests take in two functions(expect & match). I didn't actually get to writing the tests, so I can't speak too much of anymore differences.

@CheezItMan
Copy link

Ada Trader

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good commit messages and good # of commits
Comprehension questions Check
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Functionality
Quote prices change when clicking Buy and Sell Check
The Trade History updates when buying and selling a quote Check
A user can create an open order using the Order Entry Form Check
An open order removes itself from the open orders and updates the Trade History when fulfilled Check
General
Has separate views for different parts of the app Check
Uses events (listening/handling and triggering) to manage different behavior in views Check
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render) Check
Error handling for the Order Entry Form Check
Testing
Has unit tests for models MISSING
Overall Nice work, you hit all the learning goal except test writing. I made a few comment in your code, minor quibbles.

validate(order) {
if (order.isValid()) {
this.model.add(order);
this.$el.find('form').trigger('reset');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, but you could also do: this.$('form').trigger('reset'); That way you don't need to execute find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants