Pipes - Angela & Kee - VideoStore API

[anemonekey]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We used the seed data to derive the attributes needed for our models. We also noticed that for the requirements, we didn't need any relationship between the Customers and Movies. We would have needed to joint table for Rentals.
Describe a set of positive and negative test cases you implemented for a model.	For the models, we used negative test cases when checking for required fields. We also made sure that models could be created as a positive test case.
Describe a set of positive and negative test cases you implemented for a controller.	For the Movies controller, we tested whether the data was retrieved properly. We checked if the data returned as a 404 bad_response or 200 OK with all the correct data keys.
How does your API respond when bad data is sent to it?	For the Movies #create method, we tell the user the error.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	Our only real custom method was the movie_params private method for the Movies controller. We used this to pass in parameters into our create method.
Do you have any recommendations on how we could improve this project for the next cohort?	Let's keep with the times and update 'Video' to 'DVD', 'BluRay' or maybe even 'Streaming'? ;)
Link to Trello	https://trello.com/b/8jbEwFbQ/videostore
Link to ERD	Inside the Trello board

[droberts-sea]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Business Logic in Models	N/A (not much until you get to the optionals)
All 3 required endpoints return expected JSON data	yes
Requests respond with appropriate HTTP Status Code	yes
Errors are reported	yes
Testing
Passes all Smoke Tests	yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	yes
Controller Tests - URI parameters and data in the request body have positive & negative cases	yes
Overall	Great work overall!

[droberts-sea]

What if there are no customers?