sara and lauren videostore woohoo

[laurenelee]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Looking at the seed data we saw that unless we took on the rentals we did not need to have relationships between the movie and the customer. But then we essentially made a join table with rentals.
Describe a set of positive and negative test cases you implemented for a model.	A custom method we have in our movie model checks inventory. A negative test won't check the inventory if a movie does not exist.
Describe a set of positive and negative test cases you implemented for a controller.	We check that our check out method decreases the available inventory of said movie and also that it does not check out a movie that has no available inventory.
How does your API respond when bad data is sent to it?	:bad_request and :not_found
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	Checking inventory and adding inventory to the movie and also addressing a number of movies a customer has checked out.
Do you have any recommendations on how we could improve this project for the next cohort?	Rentals should probs be required... it reinforced our understanding of through relationships and testing in general.
Link to Trello	https://trello.com/b/83MRXFVd/videostore
Link to ERD	our whiteboard was erased :( sorry...

[PilgrimMemoirs]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Well Done - after drawing an ERD on paper or a whiteboard, it's still a good idea to have a digital copy - especially if there's any chance of it being changed
General
Business Logic in Models	Mostly Good - set date for due date for a rental is logic that should have model method
All 3 required endpoints return expected JSON data	Well Done
Requests respond with appropriate HTTP Status Code	Well Done
Errors are reported	Well Done
Testing
Passes all Smoke Tests	Well Done
Model Tests - all relations, validations, and custom functions test positive & negative cases	Some Improvement - make sure customer methods have more than just one positive test, also test edges and negative cases.
Controller Tests - URI parameters and data in the request body have positive & negative cases	Well Done
Optionals
POST routes use URI parameter and request body to add a new record to the database
GET /customers shows how many movies are checked out by a customer	Well Done
GET /movies/:id shows updated inventory	Well Done
Overall
	Submission meets project expectations, great work!