Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes-KimberleyZell-Calculator #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kimpossible1
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. Arrays and variables. First variables but for more complicated versions I was working on I tried using an array.
How did you determine what operation to perform? It's easier to use variables in the most basic version but doesn't work well if trying to allow user to input the full equation.
How did you make sure your program behaved correctly? As I'm going along I check each part and at the end I entered in numbers and operators to make sure. But I should have done more testing - I spent too much time working on more optionals that I was unable to finish.
Do you feel like you used consistent indentation throughout your code? Yes, and I used auto line indent to clean it up where I did not.
If you had more time, what would you have added to or changed about the program? I was working on allowing user to enter the equation, but did not get there. If I had more time I could have cleaned up my working program(s) more.

@PilgrimMemoirs
Copy link

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Well Done
Extras
Submission meets project expectations and learning goals. Nice work!
In regards to your optionals solution, whenever you see repeated code (like with checking if the number is an integer, lines 24-42), that is a great opportunity to use a method! The code is almost exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants