Calculator - Tanja Stroble

[misstonbon]

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Describe how you stored user input in your program.	I stored math operations the user chooses in a hash, words as keys and + - * / as values.
How did you determine what operation to perform?	User provided either the word or symbol and the until loop was set up to control for acceptable input.
How did you make sure your program behaved correctly?	Ran it in terminal and tried several different operations.This is where I found out that if denominator is greater than the numerator for fixnums, the result of a division is always zero, so I improved the program to set the result to float, allowing for 0.5345 and so on. Additionally, I tweaked the output a little bit. When result is an even float, i.e 4.0 , we don't really need the .0, so I fixed it so it displays just the relevant integer.
Do you feel like you used consistent indentation throughout your code?	No. I constantly tweaked the program and commented things out as I went, so I used the ctrl+alt+l often both in order to get in the habit of fixing it often, and saving code often.
If you had more time, what would you have added to or changed about the program?	I found how to do the parenthesis optional challenge on stack overflow, but was way too tired to keep going at 1 am.

[CheezItMan]

Calculator

What We're Looking For

Feature	Feedback
Takes in two numbers and an operator and performs the mathematical operation.	Check
Baseline
Readable code with consistent indentation.	Check
Extras	Handles parentheses and and combination of integers and floating point numbers.
Summary	Nice work with the primary req and the extras. I like how you adjusted for whole and decimal numbers. Good work finding the eval method. Just be careful a eval can be a security vulnerability. You can read up on why here. You do also need to be careful of zero denominators in division. Also I would move methods and code outside of methods into different sections of the document. It just makes it easier to read.

[CheezItMan]

Just a note in your code.

[CheezItMan]

Nice work on adjusting for floating point numbers.