Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guille-- Carets #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Guille-- Carets #40

wants to merge 2 commits into from

Conversation

murog
Copy link

@murog murog commented Aug 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. Stored user input as a string, and then split the string into an array that could be no longer than 3 elements: number, operation, number.
How did you determine what operation to perform? By comparing the [1] element in the string to the available operations in the calculator method.
How did you make sure your program behaved correctly? By testing all of the possible operations as well as improper input.
Do you feel like you used consistent indentation throughout your code? I think so!
If you had more time, what would you have added to or changed about the program? I would like to make a method that checks if an input is numeric without using regex.

Updates
1. Method that checked if input was numeric without using regex
2. Updated if/else statements in methods to use "case" instead
3. Added calculator with limited characters allowed on screen for result
@tildeee
Copy link

tildeee commented Aug 14, 2017

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. x
Baseline
Readable code with consistent indentation. x
Extras

@tildeee
Copy link

tildeee commented Aug 14, 2017

Great use of the case statement

I love your ASCII calculator!

@murog murog changed the title Guillermina Muro -- Carets Guille-- Carets Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants