Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marisa Morris - Calculator #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Marisa Morris - Calculator #37

wants to merge 2 commits into from

Conversation

marisamorris
Copy link

@marisamorris marisamorris commented Aug 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. Once the user was prompted for input, it was split into an array.
How did you determine what operation to perform? I used .include to check the array of acceptable operators to determine if the program should move forward and then the conditionals within the method above determine which statement to execute. For example, if the opperator is not "add or "+", move to the next statement.
How did you make sure your program behaved correctly? I made sure my program behaved correctly by ensuring the conditional statements were appropriately placed and pieces of code within were ordered correctly.
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? I noticed that certain words will stop the program and prompt the user to re-enter numbers however others will allow the conditional to continue and turn words entered into a float (0.0). I also I would have accounted for nil.

@marisamorris
Copy link
Author

Updated line 41 .

@CheezItMan
Copy link

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. Check, but it should probably prompt you to put a space between the numbers.
Baseline
Readable code with consistent indentation. Check
Extras Exponentiation
Summary Don't be so hard on your crappy calculator! I like how you ensured valid input with Array's include method. You hit all the requirements, nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants