Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jessica Owens -- Carets #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vertige
Copy link

@vertige vertige commented Aug 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. Into variables.
How did you determine what operation to perform? Using the users input, sorted it by hash where key would indicate which operation to perform.
How did you make sure your program behaved correctly? Lots of testing. In part, in irb for snippets of code, but mostly through running my program in ruby, occasionally printing extra information to see results.
Do you feel like you used consistent indentation throughout your code? I tried...
If you had more time, what would you have added to or changed about the program? I would have simplified the way I checked for numbers... My method was convoluted and left options such as 3.0.0 as valid. Would eliminate needing to check negatives, etc. (I refactored this morning and will submit an updated version... Not yet with parentheticals.) Today I would have started with a simpler thing like user_input.to_f.to_s == user_input || user.to_i.to_s == user_input. I got tired. I also would have setup parentheticals along the lines of Option B in the comments on line 142

With a bit more sleep and some nice insight from classmates today :)
@tildeee
Copy link

tildeee commented Aug 14, 2017

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. x
Baseline
Readable code with consistent indentation. two spots in code where indentation was a little off
Extras

@tildeee
Copy link

tildeee commented Aug 14, 2017

Let's loop back together soon, your code doesn't run for me

@vertige
Copy link
Author

vertige commented Aug 14, 2017 via email

@tildeee
Copy link

tildeee commented Aug 14, 2017

@vertige yup, your first commit runs. We'll look into a better way to submit code that may have helped with this (using git, lecture on Wednesday), but in general be careful about what you submit-- we'll only be checking the latest commit.

@vertige
Copy link
Author

vertige commented Aug 14, 2017 via email

@tildeee
Copy link

tildeee commented Aug 14, 2017

We check pull requests before the deadline for submission,
and we check the latest commit for giving feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants