Niambi P - Sapphire #88
Conversation
…03.py to check for failures
…ave_01 & wave_02 tests
…ides_to_string in test_wave_03.py
…st_swap_first_item_from_my_empty_returns_false & test_swap_first_item_from_their_empty_return_false.
…de so classes can inherit items attributes.
…passed all wave_05 tests.
…_category to pass wave_06 tests. Wrote wave_06 test assertions to complete wave_06 tests.
| return f"An object of type {self.get_category()} with id {self.id}." | ||
|
|
||
| def condition_description(self): |
There was a problem hiding this comment.
Be careful about indentation! The only reason that you had to copy/paste this function into your Decor, Clothing, and Electronics classes is the missing indentation before this function. If you had indented here, it would have made condition_description a member of Item, and this function would automatically have been inherited by all the other derived classes.
| return "Clothing" |
There was a problem hiding this comment.
None of your derived classes need to implement get_category because you have implemented it in their base class (Item)!
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| @pytest.mark.skip | |||
There was a problem hiding this comment.
You should remove the skips on your integration tests. If you do, you'll see there are some errors. See my comment in vendor.py for what's going on there.
| self.inventory = inventory #each vendor will have an attribute named :inventory (an empty list) |
There was a problem hiding this comment.
This is what's failing your integration tests. In Python, when you assign a "mutable" object like a list as a default value, every time the function uses that default value it will share the same instance of that object. The workaround is to use None as a default for lists and check for None in the initializer:
def __init__(self, inventory = None):
self.inventory = inventory if inventory else []^-- if you do this instead, your integration tests will pass (after you unskip them).
| self.id = uuid.uuid4().int | ||
| #if id is manually assigned | ||
| else: | ||
| self.id = id |
There was a problem hiding this comment.
A ternary is also fine here:
self.id = id if id else uuid.uuid4().int| self.remove(self.inventory[0]) | ||
| self.add(other_vendor.inventory[0]) | ||
| other_vendor.remove(other_vendor.inventory[0]) |
There was a problem hiding this comment.
[nit] This looks a lot like swap_items. You could call self.swap_items instead of rewriting very similar logic. 😄
|
|
||
| for item in self.inventory: | ||
| if item.get_category() == category: | ||
| objects.append(item) | ||
| return objects |
There was a problem hiding this comment.
Notice this pattern of:
result_list = []
for element in source_list:
if some_condition(element):
result_list.append(element)can be rewritten using a list comprehension as:
result_list = [element for element in source_list if some_condition(element)]Which here would look like:
items_in_category = [item for item in self.inventory if item.get_category() == category]
return items_in_categoryAt first, this may seem more difficult to read, but comprehensions are a very common python style, so I encourage y’all to try working with them!
| for item in items: | ||
| if item.condition >= highest_condition.condition: | ||
| highest_condition = item | ||
| return highest_condition |
There was a problem hiding this comment.
Great job using loops for this! Once you're comfortable with them, you can do this same sort of thing with the max function:
return max(items, key=lambda item: item.condition)| return False | ||
| else: | ||
| self.swap_items(other_vendor, my_best_item, their_best_item) | ||
| return True |
There was a problem hiding this comment.
[suggestion] You could also simply return self.swap_items(other_vendor, my_best_item, their_best_item), since swap_items handles None.
| assert result == True | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in jesse.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in tai.inventory | ||
| assert item_c not in tai.inventory | ||
| assert item_f not in jesse.inventory |
No description provided.