New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby - Mikayla H #84

Open

MDHowden2020 wants to merge 10 commits into Ada-C19:main from MDHowden2020:main

MDHowden2020 commented Apr 7, 2023

No description provided.

MDHowden2020 added 10 commits

April 3, 2023 11:44


          Added a comment in an effort to not be commit-phobic this project

de18297


          Completed wave 1 and wave 1 tests

024c0ae


          Completed wave 2 and unskipped tests

5815cab


          Modified wave 3 and completed wave 3 tests

ed8372f


          Completed Wave 4 and unskipped tests

59c43e2


          Completed Wave 5, modified clothing, decor, electronics and item to p…

eaa357b

…ass tests


          Modified super and removed it from each file where it wasn't necessary

ee3c09d


          Wave 6 progress and modified wave 6 tests

8e44891


          Completed wave 6 and modified tests


          Final completed project with comments included

d245ba0

nancy-harris reviewed

View reviewed changes

nancy-harris left a comment

Excellent job! There are some comments below on places to make the code cleaner/simpler. Great job on commits! It would be great if the commits could give more details about what changes were made. Something like "Created the Item class" would be great!

swap_meet/clothing.py

		from swap_meet.item import Item

		class Clothing(Item):

nancy-harris Apr 10, 2023

Excellent!

swap_meet/clothing.py

Comment on lines +16 to +17

return super().condition_description()

nancy-harris Apr 10, 2023

If the only thing you're doing is calling the super, then you don't need to override the method! If Python sees that the Clothing class does not have a condition_description method, it will look in the Item class, see it there, and use that one. Try removing this method from Clothing (and Decor and Electronics) and you'll see that all of the tests still pass!

swap_meet/decor.py

		from swap_meet.item import Item

		class Decor(Item):

nancy-harris Apr 10, 2023

Excellent!

swap_meet/electronics.py

-                  pass
+              from swap_meet.item import Item
+              class Electronics(Item):

nancy-harris Apr 10, 2023

Excellent!

swap_meet/clothing.py

Comment on lines +10 to +11

return "Clothing"

nancy-harris Apr 10, 2023

This method is not necessary! The .__class__.__name__ attribute that's used in the Item class will adjust and print the correct thing. Try deleting this method in the Clothing class (and Decor and Electronics) and the tests will still pass!

tests/unit_tests/test_wave_06.py

@@ @@ -33,12 +34,12 @@ def test_get_no_matching_items_by_category(): @@
                   items = vendor.get_by_category("Electronics")
-                  raise Exception("Complete this test according to comments below.")
+                  assert len(items) == 0

nancy-harris Apr 10, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +114 to +122

+                  assert result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_f in tai.inventory
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_c in jesse.inventory

nancy-harris Apr 10, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +156 to +166

+                  assert result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_f in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_c in jesse.inventory
+                  assert item_f not in jesse.inventory
+                  assert item_c not in tai.inventory

nancy-harris Apr 10, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +251 to +259

+                  assert not result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f in jesse.inventory

nancy-harris Apr 10, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +293 to +301

+                  assert not result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f in jesse.inventory

nancy-harris Apr 10, 2023

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet