Ruby - Thea V. #76
Ruby - Thea V. #76
Conversation
…t implementing the super was breaking my wave 5, will come back to this
|
|
||
| import uuid | ||
|
|
||
|
|
||
| class Clothing: |
There was a problem hiding this comment.
The requirements for the project stated that the Clothing, Decor, and Electronics classes should inherit from the Item class. Since this was not done, this project is a yellow.
Inheritance helps with keeping the code DRY. There is a lot of functionality that is the same between Clothing, Decor, Electronics, and Item that can be eliminated if we use inheritance.
| return f"An object of type {self.get_category()} with id {self.id}. It takes up a {self.width} by {self.length} sized space." |
There was a problem hiding this comment.
Instead of creating a helper function that's only one line, this line of code can go into the __str__ method.
| import uuid | ||
| # from swap_meet import Vendor | ||
|
|
||
|
|
||
| class Item: |
| # | ||
| def __init__(self, inventory=None): |
| self.inventory = [] | ||
|
|
||
| def add(self, item): |
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| assert result == False |
There was a problem hiding this comment.
Great start! It would be good to also have an assert to make sure the number of items in the inventory hasn't changed and that nothing was accidentally removed.
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| assert not result |
| # ********************************************************************* | ||
| # ****** Complete Assert Portion of this test ********** | ||
| # ********************************************************************* | ||
| assert len(items) == 0 |
| assert tai.inventory == [item_a, item_b, item_f] | ||
| assert jesse.inventory == [item_d, item_e, item_c] |
There was a problem hiding this comment.
Be careful using == for asserts on lists! This requires that the lists have items in exactly the same order. It would be safer to use in like the other tests in this file.
| result == True | ||
| len(tai.inventory) == 3 | ||
| len(jesse.inventory) == 3 | ||
| tai.inventory == [item_a, item_b, item_f] | ||
| jesse.inventory == [item_d, item_e, item_c] |
There was a problem hiding this comment.
It looks like the term assert is missing for these and the other tests in the rest of the file. Please make sure to remember to add assert!
No description provided.