C19 Zoisite | Yvett J. #88
Conversation
… copy and take pieces out of pool as pieces are added into the hand
| @@ -145,7 +148,8 @@ describe("Adagrams", () => { | |||
| const words = ["XXX", "XXXX", "X", "XX"]; | |||
| const correct = { word: "XXXX", score: scoreWord("XXXX") }; | |||
|
|
|||
| throw "Complete test by adding an assertion"; | |||
| // throw "Complete test by adding an assertion"; | |||
| expect(highestScoreFrom(words)).toEqual(correct); | |||
| expectScores({ | ||
| '': 0, | ||
| }) |
| @@ -1,15 +1,121 @@ | |||
| export const drawLetters = () => { | |||
| // Implement this method for wave 1 | |||
| const letters = [ | |||
There was a problem hiding this comment.
since letters is a constant variable it should be spelled with all caps like LETTERS
| let hand = []; | ||
| let letters2 = [...letters]; |
There was a problem hiding this comment.
Use const instead of let since neither variables are reassigned. A general rule of thumb for me when writing javascript is to use const and only refactor to let if the JS interpreter throws an exception when I try to reassign a variable.
Also prefer a more descriptive variable name like lettersCopy
| 'X', | ||
| 'Y', 'Y', | ||
| 'Z' | ||
| ]; |
There was a problem hiding this comment.
While it was not a requirement for this project to use a dictionary with letters for keys and number of letters for values to create a list of 98 letters, I would prefer to see you do that in order to get practice iterating over a dictionary to create a new data structure.
| }; | ||
|
|
||
| export const scoreWord = (word) => { | ||
| // Implement this method for wave 3 | ||
| const letterScores = { |
There was a problem hiding this comment.
Since this is a constant variable, we should name the variable with all caps like LETTER_SCORES
| score += 8; | ||
| } | ||
|
|
||
| for (let letter of inputLetters) { |
There was a problem hiding this comment.
Use const instead of let for the looping variable letter since the variable is not reassigned in the loop
| for (let word of words) { | ||
| let score = scoreWord(word); |
| }; | ||
|
|
||
| export const highestScoreFrom = (words) => { | ||
| // Implement this method for wave 4 | ||
| let winningWord = ''; | ||
| let topScore = 0; | ||
| let wordsWithScores = []; |
There was a problem hiding this comment.
wordsWithScores isn't ever reassigned so we should use const instead of let
| let currentWord = wordSet['word']; | ||
| let currentScore = wordSet['score']; |
No description provided.