Zoisite - Valerie V. #78
Conversation
| const LETTER_POOL = {A:9, B:2, C:2, D:4, E:12, F:2, G:3, H:2, I:9, J:1, K:1, | ||
| L:4, M:2, N:6, O:8, P:2, Q:1, R:6, S:4, T:6, U:4, V:2, W:2, X:1, Y:2, Z:1}; | ||
|
|
||
| const SCORE_CHART = {A:1, B:3, C:3, D:2, E:1, F:4, G:2, H:4, I:1, J:8, K:5, |
There was a problem hiding this comment.
Great job using upper case snake case for your global constants!
| const weightedPool = []; | ||
|
|
||
| for (let [key, value] of Object.entries(LETTER_POOL)) { | ||
| weightedPool.push(...Array(value).fill(key)); |
There was a problem hiding this comment.
I love this method of creating the weighted pool of letters! It's sleek and looks good!
| while (hand.length < 10) { | ||
| const letterIndex = Math.floor(Math.random() * weightedPool.length); | ||
| hand.push(weightedPool[letterIndex]); | ||
| weightedPool.splice(letterIndex, 1); |
| }; | ||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| const handCopy = [...lettersInHand]; |
There was a problem hiding this comment.
Good idea to use the spread operator to make a shallow copy!
|
|
||
| for (let i = 0; i < input.length; i++) { | ||
| if (handCopy.includes(input[i])) { | ||
| handCopy.shift(); |
There was a problem hiding this comment.
The shift method will always remove the first value from the list, so I don't think it's the best option for this particular method. I would say a splice method would be a better choice in this case!
| } | ||
| if (word.length >= 7) score += 8; | ||
|
|
||
| return score; | ||
| }; |
| }; | ||
|
|
||
| export const highestScoreFrom = (words) => { | ||
| // Implement this method for wave 4 | ||
| let highestScore = 0; | ||
| let topPlayers; |
There was a problem hiding this comment.
Since we are returning an object at the end, we could make this an object to begin with!
| winner = player; | ||
| } | ||
| } | ||
| return winner; | ||
| }; |
There was a problem hiding this comment.
This looks good! Well done, Valerie!
:3