Amethyst- Stacy #75
Amethyst- Stacy #75
Conversation
| @@ -1,15 +1,94 @@ | |||
| export const drawLetters = () => { | |||
| // Implement this method for wave 1 | |||
| var letters = { | |||
There was a problem hiding this comment.
I'm sure you know this now but we want to avoid using var, I think here we could use const instead.
| const weighted = (dict, randomPiece) => { | ||
| for (let [key, value] of Object.entries(dict)){ | ||
| randomPiece -= value; | ||
| if (randomPiece <= 0){ | ||
| return key; | ||
| } | ||
| } |
There was a problem hiding this comment.
Love this function! For readability we want to make sure we are placing our function definitions above the calls.
| }; | ||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| let newLetterBank = []; |
There was a problem hiding this comment.
We could make a new letter bank with the Javascript spread syntax like so newLetterBank = [...lettersInHand]
| sum += values[letter.toUpperCase()]; | ||
| } | ||
| } | ||
| return sum; |
| let maxVal = 0; | ||
| let tempScore = 0; | ||
| let maxWord = ""; |
There was a problem hiding this comment.
If we know we want to return these variables in object form, could just initialize said object here?
| maxVal = tempScore; | ||
| maxWord = word; | ||
| } | ||
| else if(maxVal == tempScore){ |
There was a problem hiding this comment.
Love the if statements in this function, they are very concise!
| } | ||
| } | ||
| }; | ||
| return {"word": maxWord, "score": maxVal}; |
There was a problem hiding this comment.
Nice job, Stacy! As you probably noticed, I didn't give too much feedback due to the scope of the project (Translating your python code to Javascript code). I tried to just point out any glaring issues, if any. With that being said, if you want to discuss anything in greater detail, feel free to reach out to me!
No description provided.