Tigers- Lindsey B. & Masha #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apradoada
reviewed
Feb 13, 2023
| <header class="header"> | ||
| Weather Report <span>for the lovely city of | ||
| <span id="headerCityName"> | ||
| Seattle |
There was a problem hiding this comment.
This is totally fine but remember that you could keep this empty and then load the default state when you begin!
| <div class="temperature_content"> | ||
| <div class="change_temperature"> | ||
| <span id="increaseTemp">⬆️</span> | ||
| <span id="temp">70</span> |
There was a problem hiding this comment.
Same thing as above! This could be loaded in from the default state!
|
|
||
|
|
||
| <script src="./node_modules/axios/dist/axios.min.js"></script> | ||
| <script src="/src/index.js"></script> |
There was a problem hiding this comment.
Overall, your html looks really good here! Well done!
| lat: 47.6062, | ||
| lon: -122.3321, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Good job creating a default state here!
| state.temp -= 1; | ||
| changeColorAndGarden(); | ||
| }; | ||
|
|
| const cityInput = document.getElementById('cityNameInput'); | ||
| cityNameInput.value = 'Seattle'; | ||
| modifyCityName(); | ||
| }; |
| .catch((error) => { | ||
| console.log('Error calling OpenWeather'); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Great job with these axios functions. The move to make them async functions was a really smart choice!
|
|
||
| getWeather(); | ||
| const getTemp = document.getElementById('getTemp'); | ||
| getTemp.addEventListener('click', getWeather); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.