C18 Lions - Julia Park #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
😞 There is no use of section or article. These should be used in many places instead of div. |
| All images include alternate text | 😞 Many images do not have alt text |
| CSS | |
| Using class and ID names in style declarations | 😞 Only uses class, no ID |
| Style declarations are DRY | ✅ |
| Uses Flexbox and/or Grid | ✅ |
| Overall | ✅ |
| <h2>My skills</h2> | ||
| </div> | ||
| <div class="project-image"> | ||
| <img src="images/skills.png" alt="skills"> |
There was a problem hiding this comment.
The alt text for images should be more descriptive. People who are blind or have low vision use screen readers to tell them what is on a webpage. Screen readers read the alt text to describe the picture to the user. This picture called "skills" will not explain to the user what is in the picture.
|
|
||
| <li> | ||
| <a href="https://www.linkedin.com/in/julia-je-park/"> | ||
| <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAABvFBMVEUAAADFxcXIyMjJycnKyMjKyMjJyMjJyMjJyMjJyMjIyMjIyMjKysrJx8fJx8fJyMjJycnJycnIyMjIyMjJyMjJyMjExMTGxsbKyMjJx8fDw8P////JycnJycnJyMjIyMj////GxsbJycnIyMjMxcXJycnJyMjJyMjIyMjKyMjV1dXJx8fMzMzJyMjJyMjJyMjKyMjJycnJycnJyMjJyMjJx8fJyMjJyMjLy8vJyMiqqqrJycnJyMjJyMjJycnJyMjHx8fJycnJycnJyMjIyMi/v7/JyMjJyMjPz8/IyMjKyMjJyMjIyMjJyMjJycnJx8fJx8e/v7/JycnJycnKx8fJycnLxsbJyMjJyMjJyMjKyMjKx8fIyMjKyMjJyMjMzMzJyMjJyMjExMTJx8fKx8fJyMjJycnKyMjIyMjJycnJyMjbtrbIyMjJx8fJyMjIyMjJyMjIyMjIyMjKx8fHx8fKyMjGxsbJyMjIyMjJycnJycnMzMzJyMjR0dHJycnKxsa/v7/KysrHx8fIyMjJycnJyMjMzMzKyMjJycnJycnIyMjJyMjJx8fJx8fJyMjKx8fJycnJyMjJyMgAAAAU5jiuAAAAknRSTlMAFlR/p83e7vqmflM1jtP+jTQOdNbVDRKBgBEBXurtbwIkxcQjUe/yWI8GpQW1tKGLVVnxz67k8CLaA2f5wmP1IHFf658I9OkQgnjQjN09cpwE3ExXkjHU/fOsfGaG+xTn/BqXUvZQfV2kzAetyuAz7CVhbjfSCYqV+FoKuAsmOgwwMqPO6A+Zt5uawYmznVYhy9RnYIYAAAABYktHRACIBR1IAAAACXBIWXMAAA7EAAAOxAGVKw4bAAAAB3RJTUUH4wQEBzMjdaXw3AAAAupJREFUWMOllntb0zAUxg8wVjZgAyYT6SgTGKhDRUFBHAICAiKOCc4h6EQHE/GCeJl3mShewAv5xK5L2jWladPx/pVzkvf35NKcBoChktIyR7lTqKgQnOUud2UJ2FJVtceLKHk9NbW87jrfIWSoep+fw364QUBMCUcaLexioAmZSmoOmvmPtiBLtbax/aF2az9CHccY9uBxHrusGsNlnHDx+hEKdxr4T/L7ETq1jyCetuNHyKVfBff6FXXR/jN2/Qidpc6/W817exznzvMAevs0G9Cipi/IV6b/YoSDMCCqgEtqcnAIZ4Z55nBZvT8jam6UpMaucADGJ8joyULuqgKd4pmCG4+t09zfawqAax8lXB98mtQ0+cKu8/gRiuYHU/VnJianhm7wATzy4CpdLjo7d7ODz49QPAeo5h1sJPmDvnUQQE+u/lP1OyFgzcsBacuf+fzthcXmOwN39YBEEkqpxD1yirNyEMPtOFqaJPX8/oOEjpCCMjaAHGl8eaVwbVLLNCANDmvAQ+3FnaMBq/CIDVgjxY4uHY8pwxN4ygbonETPKIMT1tmAMdX0fOPFSzV4pTWMQIQNeK3Um8xSLppR6scbreEtDyCK+96RcIMGmCzhPW7HJNz3QdtXWILJJn7E7U/qfmF9pjfR5Bg3cTurzJZswhf6GF2WM4grnf0GgC2zT9nPAUhDpeUSTAEh3XU2OgUzQO46g+cggK+gK2l2AZlcXMsEjFkDsnLCwwKsWQLq8wlf8QD8Y/ELDECnFYD82qChWECajG5sKg7wbRv23fDB71g/5OAnbqtF8JcuDih+EFtREdopPHGgrde+v13zyALd/4lLKaBUY9e/S/tBHLXnDwd1AOi09dj+bfBcj/3h928Z+HOr6OK0e3dFMNaKwOPv/gtM9Q1Y+3f+gYnEwLi5XVoUwVwTboltX09vg7U2o4yHm2d4k8OeV7xrSveaSvRksrxurGRqIbw3LUUi0vTe6kIoyRr3Hy3Qsh324Zt/AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDE5LTA0LTA0VDA1OjUxOjM1KzAyOjAwHE/IygAAACV0RVh0ZGF0ZTptb2RpZnkAMjAxOS0wNC0wNFQwNTo1MTozNSswMjowMG0ScHYAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb7jwaAAAAAElFTkSuQmCC" style="width:30px;height:30px;"> |
There was a problem hiding this comment.
Remember to use alt text for every picture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions