Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow Leopards - Aretta B. #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Snow Leopards - Aretta B. #118

wants to merge 3 commits into from

Conversation

arettab
Copy link

@arettab arettab commented Nov 30, 2022

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had some spaces where there shouldn't be and I needed to change some tags.
Why is it important to consider and use semantic HTML? It makes it easier for the browser to understand.
How did you decide to structure your CSS? My index and about pages are flexbox and my portfolio page is grid layout
What was the most challenging piece of this assignment? the portfolio page because it was really tedious and it was hard for me to get grid layout at first.
Describe one area that you gained more clarity on when completing this assignment I've done other layouts in HTML but this is my first time using grid view. I think with practice I will like it more than other types of layouts.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? N/A

Copy link

@marciaga marciaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I really like the design choices! Left a few specific comments but overall good structure. I'd advise considering using less IDs as they are the least flexible and least reusable styles.


#index #about {
display: flex;
Flex-Direction: Column;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Chrome is smart enough to know you meant flex-direction: column; but be sure to double check property and value names to be certain they're the correct case.

color:#4120A9;
}

#index #about {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles aren't being applied because the rule generated by space-separated selectors here is "Select any element with an ID of about that is a child of any element with an ID of index". I think you meant to use a comma to separate them, i.e.

#index, #about {
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants