made an about page with a list of hobbies #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior in the console only.
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
Mostly |
| All images include alternate text | ✅ |
| CSS | |
| Using class and ID names in style declarations | ✅ |
| Style declarations are DRY | ✅ |
| Overall | 💯 |
| <main> | ||
| <h1>About LP</h1> | ||
| <section> | ||
| <img src="../assets/me and booker.jpeg" alt="LP and their cat Booker relaxing at home"> |
There was a problem hiding this comment.
Spaces in links causes issues! This line threw an in an HTML validator
|
|
||
| <main> | ||
| Here are some books I recommend: | ||
| <ul class = "list" id="bookList"></ul> |
There was a problem hiding this comment.
There is a </ul> closing tag on this line, which closes the unordered list before any list items could be added! Errors were thrown here in the HTML validator.
| <button id="addBookButton">Add Book</button> | ||
| </section> | ||
| <section id="bookContainer"> | ||
| <h2 id = "bookCount">Book Count: 0</h2> |
There was a problem hiding this comment.
It looks like this is not intended to be a heading, but instead a counter for books. Consider using a different tag. Screen readers will get confused and think this is the heading for a new section of the page.
| @@ -0,0 +1,53 @@ | |||
| const state = { | |||
There was a problem hiding this comment.
Great start to using JS on your page!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
and
)