Fix repeatable UI bugs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 6, 2022
jacobkwan
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial UI rebuild and rework for many UI components to fix bugs.
Issue 130 can't be repeated and so can't identified and fixed.
Summary of Changes
Help Window rework
Internship Card changes and bug fixes
For all UI layouts, the company name, role, email and stage UI elements now have text wrapping enabled to prevent clipping of very long text. Issue 140
For all UI layouts, the UI elements in the internship card has been top aligned to fix text not top level aligned,
Fixed the spam clicking of tips button causing the tips to shift upwards in the tips window. Issue 124
Responsive UI changes and bug fixes
Tips panel changes and bug fixes
Fixed the centre alignment for the tips panel when there are no tips. Issue 139
Rebuilt the way the tips panel is built when there are no tips. Now the tips panel comes default with the no tips message. When there are tips, the no tips message will be cleared and the tips dynamically added. This is to aid in fixing non centre alignment of tips panel when there are no tips.
Reworked tips label for both tips panel and tips window
Rebuilt the way the tips label is built. New class file with fxml for tips card that both tips panel and tips window will use. This is to standardise the way tips are shown in both the tips panel and tips window. This is to aid in fixing the misalignment between tips index and tips in tips card.
Fixed missalignment between tips index and tips in tips card. Issue 116
Tips window and tips panel will now use the same Tips.css styling file instead of two identical TipsWindow.css and TipsPanel.css
Tips window bug fixes