Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Parcelable for ImageDefaults #95

Open
kirillt opened this issue Nov 1, 2023 · 1 comment
Open

Implement Parcelable for ImageDefaults #95

kirillt opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kirillt
Copy link
Member

kirillt commented Nov 1, 2023

Otherwise can lead to crashes.

@Serializable
data class ImageDefaults
@kirillt kirillt added the bug Something isn't working label Nov 1, 2023
@kirillt kirillt added the good first issue Good for newcomers label Nov 18, 2023
@shubertm
Copy link
Member

shubertm commented Jan 25, 2024

@kirillt Serializable is needed because we are storing ImageDefaults as JSON text. So to convert its objects to JSON and back efficiently we are using kotlinx-serialization.
Good reasons should be provided for implementing Parcelable, and that means new storage format because Parcelable is more better for sharing object across activities or fragments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants