Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete refactoring with best practices #97

Open
1 task
kirillt opened this issue Nov 1, 2023 · 1 comment
Open
1 task

Complete refactoring with best practices #97

kirillt opened this issue Nov 1, 2023 · 1 comment
Assignees
@shubertm

Comments

@kirillt
Copy link
Member

kirillt commented Nov 1, 2023 •
edited by shubertm
Loading

After #90 we have pointed out these issues to complete:

Crash:

Also this commit mentions that CI/CD needs to be fixed:

Finally:

  • ensure all FIXME and TODO are resolved, remove them from the code
@kirillt kirillt added the bounty label Nov 1, 2023
@kirillt kirillt moved this to In Progress in Development Nov 1, 2023
@kirillt kirillt moved this from In Progress to Todo in Development Nov 19, 2023
@kirillt
Copy link
Member Author

kirillt commented Jan 5, 2024

When this is done, we can eliminate develop branch.

@shubertm shubertm pinned this issue Jan 19, 2024
@kirillt kirillt moved this from Todo to In Progress in Development Jan 22, 2024
@shubertm shubertm unpinned this issue Jan 22, 2024
@shubertm shubertm mentioned this issue Jan 24, 2024
Merged
@kirillt kirillt removed the bounty label Jan 29, 2024
kirillt pushed a commit that referenced this issue Feb 1, 2024
@shubertm
#97: Complete refactoring with best practices (#105)
efe609b 
* Remove context from shareImage
* Delete getCachedImageUri
* Extract image loading from EditViewModel file
* Move all state to EditingState
* Clarify Serialization in ImageDefaults
* Fix Share
@shubertm shubertm mentioned this issue Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubertm shubertm

Labels
None yet
Projects
Development
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kirillt @isakovch @shubertm