Merge pull request #19 from ARCANEDEV/patch-1

Fixing the site name
ARCANEDEV · Oct 27, 2016 · de71737 · de71737
2 parents cf9c4d8 + d92c355
commit de71737
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/config/seo-helper.php b/config/seo-helper.php
@@ -6,8 +6,8 @@
      | ------------------------------------------------------------------------------------------------
      */
     'title' => [
-        'default'   => config('app.name', 'Laravel'),
-        'site-name' => '',
+        'default'   => 'Default Title',
+        'site-name' => config('app.name', 'My Application'),
         'separator' => '-',
         'first'     => true,
         'max'       => 55,

diff --git a/tests/Entities/TitleTest.php b/tests/Entities/TitleTest.php
@@ -135,7 +135,8 @@ public function it_can_switch_title_position()
     public function it_can_render_default_title()
     {
         $title    = $this->getDefaultTitle();
-        $expected = "<title>$title</title>";
+        $siteName = $this->getDefaultSiteName();
+        $expected = "<title>{$title} - {$siteName}</title>";
 
         $this->assertSame($expected, $this->title->render());
         $this->assertSame($expected, (string) $this->title);

diff --git a/tests/SeoMetaTest.php b/tests/SeoMetaTest.php
@@ -71,19 +71,20 @@ public function it_can_be_instantiated_by_container()
     /** @test */
     public function it_can_set_and_get_and_render_title()
     {
-        $title = 'Awesome Title';
+        $title    = 'Awesome Title';
+        $siteName = $this->getSeoHelperConfig('title.site-name');
 
         $this->seoMeta->setTitle($title);
 
-        $expected = '<title>' . $title . '</title>';
+        $expected = "<title>{$title} - {$siteName}</title>";
 
         $this->assertContains($expected, $this->seoMeta->render());
         $this->assertContains($expected, (string) $this->seoMeta);
 
         $siteName = 'Company name';
         $this->seoMeta->setTitle($title, $siteName);
 
-        $expected = '<title>' . $title . ' - ' . $siteName . '</title>';
+        $expected = "<title>{$title} - {$siteName}</title>";
 
         $this->assertContains($expected, $this->seoMeta->render());
         $this->assertContains($expected, (string) $this->seoMeta);